[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede: Add a board specific reset

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44189 )

Change subject: mb/google/dedede: Add a board specific reset
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44189/4/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/mainboard.c:

https://review.coreboot.org/c/coreboot/+/44189/4/src/mainboard/google/dedede... 
PS4, Line 15: 	google_chromeec_ap_reset();
I think you should check the return value and halt() if it succeeded, i.e.,

if (google_chromeec_ap_reset())
       halt();

and wait for the EC to reset. Otherwise, you could fall through into the global reset and then it's a race for which reset happens first