Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39454 )
Change subject: soc/intel/cannonlake: Steal no memory for disabled IGD ......................................................................
Patch Set 7:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39454/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39454/7//COMMIT_MSG@18 PS7, Line 18: * FSP-M crashes if InternalGfx is set to zero or CPU without IGD is
needs update that a workaround has been found
Ack
https://review.coreboot.org/c/coreboot/+/39454/6/src/soc/intel/cannonlake/ro... File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/39454/6/src/soc/intel/cannonlake/ro... PS6, Line 36: if (config->InternalGfx == 0) {
Looking at skylake, it's even better. […]
Ack
https://review.coreboot.org/c/coreboot/+/39454/6/src/soc/intel/cannonlake/ro... PS6, Line 158: /* Fix broken FSPM */
add FSP version number
Ack
https://review.coreboot.org/c/coreboot/+/39454/6/src/soc/intel/cannonlake/ro... PS6, Line 159: if (config->InternalGfx == 0)
m_cfg->InternalGfx == 0
Ack
https://review.coreboot.org/c/coreboot/+/39454/7/src/soc/intel/cannonlake/ro... File src/soc/intel/cannonlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/39454/7/src/soc/intel/cannonlake/ro... PS7, Line 39: SA_DEV_IGD
dev
Ack