[coreboot-gerrit] Change in coreboot[master]: intel/common/block/gpio: only reset configured SMI instead of all

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48089 )

Change subject: intel/common/block/gpio: only reset configured SMI instead of all
......................................................................

Patch Set 10:

(2 comments)

https://review.coreboot.org/c/coreboot/+/48089/10/src/soc/intel/common/block... 
File src/soc/intel/common/block/gpio/gpio.c:

https://review.coreboot.org/c/coreboot/+/48089/10/src/soc/intel/common/block... 
PS10, Line 169: en_reg = GPI_SMI_EN_OFFSET(comm, group);
> nit: This didn't really have to move up from line 175.

yes, it didn't have to, I just did it for consistency

https://review.coreboot.org/c/coreboot/+/48089/10/src/soc/intel/common/block... 
PS10, Line 170: en_value
> or maybe gpio_bitmask?

I used en_value, because it actually is the bitmask of the enabled smi. Since we need to reset the enabled one, using it with that name for reset, shouldn't hurt