Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37651 )
Change subject: mainboard/variant/puff: set initial PL values for puff
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37651/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/puff/variant.c:
https://review.coreboot.org/c/coreboot/+/37651/1/src/mainboard/google/hatch/...
PS1, Line 66: pl4 = 0;
Seems like you could invert the if stmt and avoid a else branch then have the sane safe defaults set here. Also separate these two onto their own lines with a comment before them explaining its a safe default.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37651
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I041ebaa33bf2582386198290e625099ba8e2f3c9
Gerrit-Change-Number: 37651
Gerrit-PatchSet: 1
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 11 Dec 2019 07:06:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment