build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36543 )
Change subject: drivers/intel/fsp1_1: Do not use prog_locate if VBOOT_STARTS_IN_ROMSTAGE ......................................................................
Patch Set 2:
(7 comments)
https://review.coreboot.org/c/coreboot/+/36543/2/src/drivers/intel/fsp1_1/ca... File src/drivers/intel/fsp1_1/car.c:
https://review.coreboot.org/c/coreboot/+/36543/2/src/drivers/intel/fsp1_1/ca... PS2, Line 46: trailing whitespace
https://review.coreboot.org/c/coreboot/+/36543/2/src/drivers/intel/fsp1_1/ca... PS2, Line 46: code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/36543/2/src/drivers/intel/fsp1_1/ca... PS2, Line 46: please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/36543/2/src/drivers/intel/fsp1_1/ca... PS2, Line 47: /* If VBOOT_STARTS_IN_ROMSTAGE is enabled prog_locate should be not be used before trailing whitespace
https://review.coreboot.org/c/coreboot/+/36543/2/src/drivers/intel/fsp1_1/ca... PS2, Line 47: /* If VBOOT_STARTS_IN_ROMSTAGE is enabled prog_locate should be not be used before line over 96 characters
https://review.coreboot.org/c/coreboot/+/36543/2/src/drivers/intel/fsp1_1/ca... PS2, Line 48: * memory is available. Doing so will cause the vboot_locate to be called too early. trailing whitespace
https://review.coreboot.org/c/coreboot/+/36543/2/src/drivers/intel/fsp1_1/ca... PS2, Line 48: * memory is available. Doing so will cause the vboot_locate to be called too early. line over 96 characters