Attention is currently required from: David Wu, Tarun Tuli, Henry Sun, Ren Kuo, Tyler Wang, Eric Lai.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72051 )
Change subject: mb/google/nissa/var/craask: Modify clkreq to clksrc mapping
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/brya/variants/craask/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/72051/comment/e090203b_de237d20
PS3, Line 448: # Setting clk_src=2 and clk_req=2 in coreboot,and swap to clk_src=1,clk_req=2 in mFIT
Can you clarify in the comment - "Due to inconsistency between PMC firmware and FSP, we need to set clk_src to clk_req number, not same as hardware mapping"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72051
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia057dfa98cb9293d9e212edb4e4ac198e94e8985
Gerrit-Change-Number: 72051
Gerrit-PatchSet: 3
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Simon Yang
simon1.yang@intel.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 02 Feb 2023 22:52:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment