Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34493 )
Change subject: Documentation/mainboard/amd: Add padmelon documentation and images ......................................................................
Patch Set 3:
(9 comments)
https://review.coreboot.org/c/coreboot/+/34493/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34493/1//COMMIT_MSG@7 PS1, Line 7: doucumentation documentation
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/Padmelon.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... PS1, Line 20: The picture was extracted from manual, however, the numbering on the padmelon board is misplaced. All markdown lines need to be wrapped at a maximum of 72 characters. https://doc.coreboot.org/getting_started/writing_documentation.html#basic-an...
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... PS1, Line 40: no, use dediprog Now I'm curious about what "in circuit flashing" means.
1) I'd assume you can flash it from the host. 2) If you can flash with dediprog and the host, then what else qualifies as in-circuit?
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon.jpg:
PS1: Images should have a max width of 700 pixels: https://doc.coreboot.org/getting_started/writing_documentation.html#basic-an...
What's the copyright on this photo? Maybe you can take your own photos instead of using these that are probably not publicly distributable.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon_components.jpg:
PS1: This might be better included as text.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon_io.jpg:
PS1: Again, take your own photo? If you need help labeling it, I could help with that.
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/mainboard/amd... File Documentation/mainboard/amd/padmelon/padmelon_io_description.jpg:
PS1: Again, text instead of an image?
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/index... File Documentation/soc/amd/index.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/index... PS1, Line 5: ## Technology Make the merlin falcon documentation a separate commit?
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... File Documentation/soc/amd/merlinfalcon.md:
https://review.coreboot.org/c/coreboot/+/34493/1/Documentation/soc/amd/merli... PS1, Line 3: ## Abstract Add links via the internet archive?
https://web.archive.org/web/20190617113113/https://developer.amd.com/resourc...