Attention is currently required from: Furquan Shaikh, Bhanu Prakash Maiya, EricR Lai.
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52181 )
Change subject: mb/google/guybrush/var/guybrush: Add FPMCU configration
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/guybrush/variants/guybrush/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/52181/comment/92df2074_9e3828bc
PS9, Line 113: register "has_power_resource" = "1"
I tried configure GPIO_32 to high and GPIO_11 to low in "early_gpio_table" then de-assert reset in […]
Are the signals GPIO_11(reset) and GPIO_32(enable) driven low at reset?
=> GPIO_11 is default PU from PPR, GPIO_32 shows n/a.
GPIO_11 should not be driven low in early_gpio_table. Else it will break the case of S3 resume.
=> FP seems not working if not configuring GPIO_11(reset) to low in early_gpio_table
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52181
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c56b0db193be6804d07c2f333445c2a1dbf9f59
Gerrit-Change-Number: 52181
Gerrit-PatchSet: 9
Gerrit-Owner: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 09 Apr 2021 05:02:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment