Attention is currently required from: Felix Singer, Nicholas Chin.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80311?usp=email )
Change subject: docker/doc.coreboot.org: Install pip modules into virtual env
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
Patchset:
PS6:
The CI doesn't verify this, so I'm assuming it's been verified manually.
I question putting the venv at / instead of in a user folder under home, but that's minor.
does the venv actually get added to the path environment? do you still need to activate the venv?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80311?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idd9cc5e6fb28b42ef8e4fa5db01eb9ef192ba0ec
Gerrit-Change-Number: 80311
Gerrit-PatchSet: 6
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Sun, 17 Mar 2024 20:34:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment