Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37212 )
Change subject: arch/x86/exit_car.S: Make sure _cbmem_top_ptr hits dram
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37212/4/src/arch/x86/exit_car.S
File src/arch/x86/exit_car.S:
https://review.coreboot.org/c/coreboot/+/37212/4/src/arch/x86/exit_car.S@44
PS4, Line 44: btl $19, %edx
Can we add #defines for some of these bit fields somewhere?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37212
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37681ee1f1d2ae5f9dd824b5baf7b23b2883b1dc
Gerrit-Change-Number: 37212
Gerrit-PatchSet: 6
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 07 Aug 2020 16:21:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment