Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41949 )
Change subject: soc/mediatek/mt8183: Add ddr geometry to support 6GB, 8GB DDR bootup ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41949/12//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41949/12//COMMIT_MSG@10 PS12, Line 10: information Line too long. Please put this in the next line.
https://review.coreboot.org/c/coreboot/+/41949/12/src/soc/mediatek/mt8183/in... File src/soc/mediatek/mt8183/include/soc/emi.h:
https://review.coreboot.org/c/coreboot/+/41949/12/src/soc/mediatek/mt8183/in... PS12, Line 9: struct sdram_params { May I ask why you decided to NOT move this to dramc_param.h?