Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39236 )
Change subject: mb/google/dedede: Enable trackpad support ......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39236/9//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39236/9//COMMIT_MSG@12 PS9, Line 12: Add TEST information. Please include that with the I2C rise/fall/hold time configuration, I2C clock frequency was measured to be 350 KHz.
https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39236/4/src/mainboard/google/dedede... PS4, Line 36: PAD_CFG_GPI_APIC
I see GPE STS set in PMC reg corresponding to B3(GPE_DW0_03), should trigger wake.
So no need to dual route the IRQ to SCI and IOAPIC?
I see that it is done that way in Hatch and it has the concerned GPIO group(GPP_A21) routed to GPE_DW0.
https://review.coreboot.org/c/coreboot/+/39236/2/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39236/2/src/mainboard/google/dedede... PS2, Line 24: .rise_time_ns = 66, : .fall_time_ns = 90, : .data_hold_time_ns = 350
Hi Karthik, […]
Done