Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46509 )
Change subject: mrc_cache: Add config MRC_SAVE_HASH_IN_TPM ......................................................................
Patch Set 4: Code-Review+2
(2 comments)
LGTM once the two comments are resolved: 1. Making option user visible 2. Do we want to drop the "if CHROMEOS" condition for the config. If yes, can you please send out a PSA to coreboot mailing list?
https://review.coreboot.org/c/coreboot/+/46509/2/src/drivers/mrc_cache/Kconf... File src/drivers/mrc_cache/Kconfig:
https://review.coreboot.org/c/coreboot/+/46509/2/src/drivers/mrc_cache/Kconf... PS2, Line 55: n
I agree that this has nothing to do with Chrome OS only. […]
I am looking at all TPM2 boards and not just the ones using FSP2.0+ because by the end of this patch series, we would have this Kconfig enabling hash spaces for both recovery and non-recovery cases and the calls moved to mrc_cache driver. So, it will add this new space for all the current TPM2 boards.
https://review.coreboot.org/c/coreboot/+/46509/4/src/drivers/mrc_cache/Kconf... File src/drivers/mrc_cache/Kconfig:
https://review.coreboot.org/c/coreboot/+/46509/4/src/drivers/mrc_cache/Kconf... PS4, Line 53: bool Julius had a comment on earlier patchset that this option should be made user visible.