Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35204 )
Change subject: [TEST-ONLY] Distinguish SKU1 and 2 for eMMC and SSD respectively
......................................................................
Patch Set 3:
Patch Set 3:
May I consult what is bad thing for enabling eMMC and SSD controller always? Thanks.
Dear Marco, if enable both MDIO and PCI-E controller, DUT may encounter interrupt storm since have relevant GPIOs(MDIO or PCI-E) not be closed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35204
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I827e6f1420801d43e0eb4708b8b8ad1692ef7e9f
Gerrit-Change-Number: 35204
Gerrit-PatchSet: 3
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Marco Chen
marcochen@google.com
Gerrit-Comment-Date: Thu, 05 Sep 2019 02:17:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment