[coreboot-gerrit] Change in coreboot[master]: timestamp,amd/common/apob_cache: Add timestamps for APOB

[Angel Pons (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Karthik Ramasubramanian, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55401 )

Change subject: timestamp,amd/common/apob_cache: Add timestamps for APOB
......................................................................

Patch Set 1: Code-Review+2

(1 comment)

File src/soc/amd/common/block/apob/apob_cache.c:

https://review.coreboot.org/c/coreboot/+/55401/comment/3981a0bc_96a5b3f6 
PS1, Line 143: timestamp_add_now(TS_AMD_APOB_ERASE_START);
             : 
             : 	/* write data to flash region */
             : 	if (rdev_eraseat(&write_rdev, 0, DEFAULT_MRC_CACHE_SIZE) < 0) {
             : 		printk(BIOS_ERR, "Error: APOB flash region erase failed\n");
             : 		return;
             : 	}
             : 
             : 	timestamp_add_now(TS_AMD_APOB_WRITE_START);
             : 
             : 	if (rdev_writeat(&write_rdev, apob_src_ram, 0, apob_src_ram->size) < 0) {
             : 		printk(BIOS_ERR, "Error: APOB flash region update failed\n");
             : 		return;
             : 	}
> I think the APOB data only really changes when we update firmware versions.

Hmmm, then I'd say it's not worth the hassle.
> Do we have existing code to calculate the diffs and only erase-update those blocks?

Not that I know of.