Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35204 )
Change subject: [TEST-ONLY] Distinguish SKU1 and 2 for eMMC and SSD respectively ......................................................................
Patch Set 4:
Patch Set 4:
Patch Set 4:
Whether eMMC or SSD in M/B will be locked down during SMT by BOM therefore could we take care of that for non-mounting one (either eMMC or SSD) we can fine-tune pins for N/C, PU or PD to avoid any leakage or interrupt storm? As a result, at least we can support 255?
Dear Marco, sorry feedback to you later. I confirmed with our factory team and PM, Proto board just power on, BTW don't do factory flow. So I think SKU255 for Proto build that is fine.
Even for proto stage, the SKU ID 255 still needs to be ensure that board can be power on generally; otherwise everyone got this board needs to re-program SKU ID by servo console?
Considering to EVT, we still need to evaluate to boot up by 255.
1. Even for proto stage, the SKU ID 255 still needs to be ensure that board can be power on generally; otherwise everyone got this board needs to re-program SKU ID by servo console? [Peichao:] your mean, DUT will bring up whatever the SKU ID is 1 or 2?
2. Considering to EVT, we still need to evaluate to boot up by 255. [Peichao:] Sure, this CL has included this logic, we can bring up normally from eMMC or SSD when SKU ID is 255