Attention is currently required from: Hung-Te Lin. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60317 )
Change subject: soc/mediatek/mt8186: Add devapc basic drivers ......................................................................
Patch Set 4: Verified+1
(9 comments)
File src/soc/mediatek/mt8186/include/soc/devapc.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136085): https://review.coreboot.org/c/coreboot/+/60317/comment/fa63fd58_bfa68397 PS4, Line 68: #define DAPC_PERM_ATTR_4(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136085): https://review.coreboot.org/c/coreboot/+/60317/comment/868b6221_4e6c200b PS4, Line 73: #define DAPC_PERM_ATTR_8(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136085): https://review.coreboot.org/c/coreboot/+/60317/comment/82d023c9_598d50b9 PS4, Line 81: #define DAPC_PERM_ATTR_16(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136085): https://review.coreboot.org/c/coreboot/+/60317/comment/e01f0a57_4743752a PS4, Line 95: #define FORBIDDEN3 FORBIDDEN, FORBIDDEN, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136085): https://review.coreboot.org/c/coreboot/+/60317/comment/eec6b165_ccac0ab1 PS4, Line 96: #define FORBIDDEN4 FORBIDDEN3, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136085): https://review.coreboot.org/c/coreboot/+/60317/comment/21f6d0ef_2a84f883 PS4, Line 97: #define FORBIDDEN5 FORBIDDEN4, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136085): https://review.coreboot.org/c/coreboot/+/60317/comment/660af199_17a65ba6 PS4, Line 98: #define FORBIDDEN6 FORBIDDEN5, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136085): https://review.coreboot.org/c/coreboot/+/60317/comment/f1d39cd4_779cd3d9 PS4, Line 99: #define FORBIDDEN7 FORBIDDEN6, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136085): https://review.coreboot.org/c/coreboot/+/60317/comment/3ea49920_70e990ad PS4, Line 101: #define NO_PROTECTION4 NO_PROTECTION, NO_PROTECTION, NO_PROTECTION, NO_PROTECTION Macros with complex values should be enclosed in parentheses