Attention is currently required from: Daniel Peng, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79976?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/dedede/var/galtic: Correct the Memory Part Name
......................................................................
Patch Set 4:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79976/comment/00f9a9bd_8f89f1d0 :
PS4, Line 7: Correct the Memory Part Name
Correct name for mem-part K4U6E3S4AA-MGCR
https://review.coreboot.org/c/coreboot/+/79976/comment/cfa1ebca_6c0ddacf :
PS4, Line 9: memtion
mentioned?
https://review.coreboot.org/c/coreboot/+/79976/comment/a606c8f8_74983a8a :
PS4, Line 11:
Please only one space.
https://review.coreboot.org/c/coreboot/+/79976/comment/4221de7c_6ff4a08e :
PS4, Line 13:
How could this mistake happen? Was there a bug in the script?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79976?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7c158eb7b4455cde839a335913e6a18895c12b41
Gerrit-Change-Number: 79976
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Daniel Peng
daniel_peng@pegatron.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 15 Jan 2024 17:19:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment