Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44999 )
Change subject: Revert "util/spd_tools: output binaries instead of hexdumps"
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/44999/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44999/2//COMMIT_MSG@11
PS2, Line 11: Reason for revert: This change breaks compatibility if the changes in CB:44775 are not also included. CB:44775 is still under discussion, so reverting this change to make spd_tools usable again.
Please wrap at 72 characters
https://review.coreboot.org/c/coreboot/+/44999/2//COMMIT_MSG@11
PS2, Line 11: reverting
revert
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44999
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5840a1b895dcbc8b91c76d8b60df2f95b93a4370
Gerrit-Change-Number: 44999
Gerrit-PatchSet: 2
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 02 Oct 2020 15:09:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment