Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45047 )
Change subject: sb/intel/lynxpoint: Do not determine PCH type at runtime ......................................................................
Patch Set 3: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/45047/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45047/3//COMMIT_MSG@7 PS3, Line 7: Do not determine PCH type at runtime Maybe motivate this by stating that determining this at buildtime allows the compiler to optimize out unused code?
https://review.coreboot.org/c/coreboot/+/45047/3/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/early_pch.c:
https://review.coreboot.org/c/coreboot/+/45047/3/src/southbridge/intel/lynxp... PS3, Line 40: get_pch_platform_type() == PCH_TYPE_ULT Outside the scope of this CL: would asserting (get_pch_platform_type() == CONFIG(INTEL_LYNXPOINT_LP)) somewhere be useful?