Attention is currently required from: Anil Kumar K, Paul Menzel, Angel Pons, Nick Vaccaro.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70796 )
Change subject: mb/google/brya: Define a more suitable MRC training text message
......................................................................
Patch Set 20:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/70796/comment/89c059dc_82cb04b6
PS20, Line 336: \
Is this double backslash a newline? Interesting.
I would rather have use the regular newline character ('\n') but it unfortunately is lost when it turns into C code. Doubling the backslash did not work either.
'\' is a simple way I found to offer the flexibility I was looking for.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/70796
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie71cd86746427789b3694d41224bf2c170af0f91
Gerrit-Change-Number: 70796
Gerrit-PatchSet: 20
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Wed, 21 Dec 2022 17:07:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment