build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41413 )
Change subject: Revert "device: Enable resource allocator to use multiple ranges" ......................................................................
Patch Set 1:
(12 comments)
https://review.coreboot.org/c/coreboot/+/41413/1/src/device/device.c File src/device/device.c:
https://review.coreboot.org/c/coreboot/+/41413/1/src/device/device.c@328 PS1, Line 328: struct bus* link; "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/41413/1/src/device/device.c@398 PS1, Line 398: if ((base & 0x300) != 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/41413/1/src/device/device.c@405 PS1, Line 405: else if ((base >= 0x3b0) && (base <= 0x3df)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/41413/1/src/device/device.c@494 PS1, Line 494: if ((base & 0x300) != 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/41413/1/src/device/device.c@501 PS1, Line 501: else if ((base >= 0x3b0) && (base <= 0x3df)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/c/coreboot/+/41413/1/src/device/device.c@561 PS1, Line 561: struct bus* link; "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/41413/1/src/device/device.c@576 PS1, Line 576: IOINDEX_LINK(child_bridge->index)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41413/1/src/device/device.c@615 PS1, Line 615: struct constraints* limits) "foo* bar" should be "foo *bar"
https://review.coreboot.org/c/coreboot/+/41413/1/src/device/device.c@642 PS1, Line 642: if (((res->base + res->size -1) < lim->base) need consistent spacing around '-' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/41413/1/src/device/device.c@655 PS1, Line 655: if ((signed long long)(lim->limit - (res->base + res->size -1)) need consistent spacing around '-' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/41413/1/src/device/device.c@659 PS1, Line 659: lim->limit = res->base -1; need consistent spacing around '-' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/41413/1/src/device/device.c@1045 PS1, Line 1045: for (child = root->link_list->children; child; child=child->sibling) spaces required around that '=' (ctx:VxV)