Attention is currently required from: Felix Singer, Tim Wawrzynczak, Angel Pons, Michael Niewöhner, Patrick Rudolph.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61212 )
Change subject: soc/intel/tgl: add panel and backlight setup
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
Sorry, looks like I missed that one comment earlier.
File src/soc/intel/tigerlake/graphics.c:
https://review.coreboot.org/c/coreboot/+/61212/comment/11aa6c53_5ebb87ad
PS2, Line 54: }
Yes, actually I was thinking about doing that but wasn't sure yet, where to put the code. […]
It's part of the silicon init, imo. So I'd keep it in soc/intel/.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61212
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I53af4d2f8423b30630d70b877862d07eccbd5202
Gerrit-Change-Number: 61212
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 23 Jan 2022 15:06:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment