Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39886 )
Change subject: soc/amd/picasso: Add helper functions for finding SOC type
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39886/1/src/soc/amd/picasso/soc_uti...
File src/soc/amd/picasso/soc_util.c:
https://review.coreboot.org/c/coreboot/+/39886/1/src/soc/amd/picasso/soc_uti...
PS1, Line 26: RAVEN2_CPUID
So internally we have a additional check for dali_3250U
https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th...
Are you going to add that in a followup?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39886
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I24b73145cdfa80c09fbe036d1fb6079696c6d013
Gerrit-Change-Number: 39886
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Fri, 27 Mar 2020 20:16:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment