Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30978 )
Change subject: google/kukui: Change TPM interface from SPI to I2C ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30978/2/src/mainboard/google/kukui/verstage.... File src/mainboard/google/kukui/verstage.c:
https://review.coreboot.org/#/c/30978/2/src/mainboard/google/kukui/verstage.... PS2, Line 26: if (IS_ENABLED(CONFIG_BOARD_GOOGLE_KUKUI) && board_id() < 2) { : die("This board is no longer supported. " : "Please use older AP firmware.\n"); : }
Or just deprecate rev1 (this CL can still be reverted to build FW for rev1 as long as we need them): […]
I think during the transition we do want something to make it easier identifying if people has installed wrong firmware, especially we're recently delivering both P1 and P2 firmware at the same time.
@youcheng, what about moving the board_id check to a separate CL, mark as DO NOT MERGE, and only apply it in your local P2 builds? (i.e., it does not need to live in review.coreboot.org, can be in chromium gerrit)