Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44918 )
Change subject: drivers/intel/usb4: Add driver for USB4 retimer device ......................................................................
Patch Set 5:
(5 comments)
https://review.coreboot.org/c/coreboot/+/44918/5/src/drivers/intel/usb4/reti... File src/drivers/intel/usb4/retimer/Kconfig:
https://review.coreboot.org/c/coreboot/+/44918/5/src/drivers/intel/usb4/reti... PS5, Line 3: help depends on HAVE_ACPI_TABLES
https://review.coreboot.org/c/coreboot/+/44918/5/src/drivers/intel/usb4/reti... File src/drivers/intel/usb4/retimer/retimer.c:
https://review.coreboot.org/c/coreboot/+/44918/5/src/drivers/intel/usb4/reti... PS5, Line 7: device/i2c_simple.h Is this required?
https://review.coreboot.org/c/coreboot/+/44918/5/src/drivers/intel/usb4/reti... PS5, Line 65: / Read power gpio into Local0 Why is this required? Can we not simply make a call to enable/disable without looking at the current state? Setting to the same state should be harmless.
https://review.coreboot.org/c/coreboot/+/44918/5/src/drivers/intel/usb4/reti... PS5, Line 118: struct const
https://review.coreboot.org/c/coreboot/+/44918/5/src/drivers/intel/usb4/reti... PS5, Line 118: dev->chip_info config_of(dev)