Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34658 )
Change subject: soc/intel/common/block/acpi: Add provision to inject PCI PIRQ ACPI mapping
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34658/5/src/soc/intel/common/block/...
File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/34658/5/src/soc/intel/common/block/...
PS5, Line 242:
: acpigen_write_scope("\");
: acpigen_write_name("PIRX");
: acpigen_write_package(num_entries);
Tim , I tried setting the scope to _SB. […]
Hm, that's weird. I guess let's just go with it for now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34658
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60ae7cbcfe53c4cb21e88997b06ec8af4b59b844
Gerrit-Change-Number: 34658
Gerrit-PatchSet: 6
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 02 Oct 2019 19:39:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment