Attention is currently required from: Joel Linn, Matt DeVillier.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81426?usp=email )
Change subject: superio/ite: Add special fan vectors and further options ......................................................................
Patch Set 4:
(1 comment)
File src/superio/ite/common/env_ctrl.c:
https://review.coreboot.org/c/coreboot/+/81426/comment/22f97944_47779e46 : PS1, Line 369: #endif
A new C file would still require the code to be called from somewhere and thus yield similar "proble […]
tl;dr I think you'd just have to free the API from the problematic index.
AFAICT, you'd have to move all the code that references `->fan_vector[]` or the index. So that includes the `for` loop here that could be moved into an additional function. When configuring the Makefile.mk to only build it with the Kconfig set, e.g. ``` ramstage-$(CONFIG_SUPERIO_ITE_ENV_CTRL_FAN_VECTOR) += env_ctrl_fan_vector.c ``` the compiler would never see the code unless ITE_EC_FAN_VECTOR_COUNT is 2.