Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30931 )
Change subject: soc/intel/denverton_ns: Allow using FSP repo
......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/30931/3/src/soc/intel/denverton_ns/...
File src/soc/intel/denverton_ns/Kconfig:
https://review.coreboot.org/c/coreboot/+/30931/3/src/soc/intel/denverton_ns/...
PS3, Line 82: string "Location of FSP headers"
I don't understand it. Why does it need a prompt now? and didn't need […]
Done
https://review.coreboot.org/c/coreboot/+/30931/3/src/soc/intel/denverton_ns/...
PS3, Line 88: default "3rdparty/fsp/DenvertonNSFspBinPkg/FspBin/DenvertonNSFsp.fd"
I really don't care about the existing weirdness. If you don't want to […]
I can do that in a follow-up patch, but I don't think this is the right patch to change this, since it would break the consistency compared to the other FSP platforms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30931
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I615305da5865bef305f560f5c90482cf0937b25a
Gerrit-Change-Number: 30931
Gerrit-PatchSet: 12
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Julien Viard de Galbert
coreboot-review-ju@vdg.name
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Tue, 03 Mar 2020 21:16:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment