Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35951 )
Change subject: nb/intel/nehalem: Move to C_ENVIRONMENT_BOOTBLOCK ......................................................................
Patch Set 3:
(4 comments)
Sorry, I'm a little confused by the console setup.
1. I don't think we should `select` a console option with a prompt. 2. This is more general: If one opts out from bootblock console, does this disable romstage console too? I can't find a romstage call to console_init() on other platforms either. :-/
https://review.coreboot.org/c/coreboot/+/35951/3/src/mainboard/lenovo/x201/e... File src/mainboard/lenovo/x201/early_init.c:
https://review.coreboot.org/c/coreboot/+/35951/3/src/mainboard/lenovo/x201/e... PS3, Line 6: * Copyright (C) 2013 Vladimir Serbinenko phcoder@gmail.com Five times copyright for a single line? I think the last one is accurate.
https://review.coreboot.org/c/coreboot/+/35951/3/src/northbridge/intel/nehal... File src/northbridge/intel/nehalem/Kconfig:
https://review.coreboot.org/c/coreboot/+/35951/3/src/northbridge/intel/nehal... PS3, Line 25: select BOOTBLOCK_CONSOLE Didn't we decide to leave this choice to the user?
https://review.coreboot.org/c/coreboot/+/35951/3/src/northbridge/intel/nehal... File src/northbridge/intel/nehalem/romstage.c:
https://review.coreboot.org/c/coreboot/+/35951/3/src/northbridge/intel/nehal... PS3, Line 51: console_init(); No console_init() in romstage?
https://review.coreboot.org/c/coreboot/+/35951/3/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/early_pch.c:
https://review.coreboot.org/c/coreboot/+/35951/3/src/southbridge/intel/ibexp... PS3, Line 27: static void early_lpc_init(void) As usual, I'd prefer to move the bootblock code to `bootblock.c`.