Attention is currently required from: Evgeny Zinoviev, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33102 )
Change subject: ec/apple: Add ACPI code for Apple MacBooks
......................................................................
Patch Set 21:
(4 comments)
File src/ec/apple/acpi/ac.asl:
PS17:
We use SPDX license headers now
Done
File src/ec/apple/acpi/battery.asl:
https://review.coreboot.org/c/coreboot/+/33102/comment/9405825a_8969be11
PS17, Line 80: 0xFFFFFFFF, // 1: Design cap
Poke
Done
https://review.coreboot.org/c/coreboot/+/33102/comment/450efb27_00449267
PS17, Line 132:
What's with these spaces?
Done
File src/ec/apple/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/33102/comment/872b328f_5215c00e
PS17, Line 43: 0x62
Still not changed?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33102
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d4585aac8e3ebbfed6ce4d4e39fbc33ac983069
Gerrit-Change-Number: 33102
Gerrit-PatchSet: 21
Gerrit-Owner: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 03 Feb 2021 18:36:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Evgeny Zinoviev
me@ch1p.io
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment