Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52697 )
Change subject: amdfwtool: Cleanup the message of help ......................................................................
amdfwtool: Cleanup the message of help
1. Wrap the long lines. 2. Align the message. 3. Add new SOC name, Cezanne. 4. Fix the cases.
Change-Id: Id537d7c9b77641289274c1b2b6f606e2be37ac6b Signed-off-by: Zheng Bao fishbaozi@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/52697 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M util/amdfwtool/amdfwtool.c 1 file changed, 9 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index b2b7c42..46910cb 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -170,9 +170,10 @@ printf("-p | --load-mp2-fw Set if load MP2 firmware\n"); printf("-L | --load-s0i3 Set if load s0i3 firmware\n"); printf("-Z | --verstage <FILE> Add verstage\n"); - printf("-E | --verstage_sig Add verstage signature"); + printf("-E | --verstage_sig Add verstage signature\n"); printf("\nBIOS options:\n"); - printf("-I | --instance <number> Sets instance field for the next BIOS firmware\n"); + printf("-I | --instance <number> Sets instance field for the next BIOS\n"); + printf(" firmware\n"); printf("-a | --apcb <FILE> Add AGESA PSP customization block\n"); printf("-Q | --apob-base <HEX_VAL> Destination for AGESA PSP output block\n"); printf("-F | --apob-nv-base <HEX_VAL> Location of S3 resume data\n"); @@ -182,7 +183,7 @@ printf("-e | --bios-bin-src <HEX_VAL> Address in flash of source if -V not used\n"); printf("-v | --bios-bin-dest <HEX_VAL> Destination for uncompressed BIOS\n"); printf("-j | --bios-uncomp-size <HEX> Uncompressed size of BIOS image\n"); - printf("\n-o | --output <filename> output filename\n"); + printf("-o | --output <filename> Output filename\n"); printf("-f | --flashsize <HEX_VAL> ROM size in bytes\n"); printf(" size must be larger than %dKB\n", MIN_ROM_KB); @@ -190,10 +191,12 @@ printf("-l | --location Location of Directory\n"); printf("-q | --anywhere Use any 64-byte aligned addr for Directory\n"); printf("-R | --sharedmem Location of PSP/FW shared memory\n"); - printf("-P | --sharedmem-size Maximum size of the PSP/FW shared memory area\n"); + printf("-P | --sharedmem-size Maximum size of the PSP/FW shared memory\n"); + printf(" area\n"); printf("-C | --soc-name <socname> Specify SOC name. Supported names are\n"); - printf(" Stoneyridge, Raven, Picasso, Renoir or Lucienne"); - printf("-h | --help show this help\n"); + printf(" Stoneyridge, Raven, Picasso, Renoir, Cezanne\n"); + printf(" or Lucienne\n"); + printf("-h | --help Show this help\n"); printf("\nEmbedded Firmware Structure options used by the PSP:\n"); printf("--spi-speed <HEX_VAL> SPI fast speed to place in EFS Table\n"); printf(" 0x0 66.66Mhz\n");