[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: add TCC activation functionality

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41855 )

Change subject: soc/intel/common: add TCC activation functionality
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41855/9/src/soc/intel/common/block/... 
File src/soc/intel/common/block/cpu/cpulib.c:

https://review.coreboot.org/c/coreboot/+/41855/9/src/soc/intel/common/block/... 
PS9, Line 271: 	msr = rdmsr(MSR_TEMPERATURE_TARGET);
             : 	/* Time Window Tau Bits [6:0] */
             : 	msr.lo &= ~0x7f;
             : 	msr.lo |= 0xe6; /* setting 100ms thermal time window */
             : 	wrmsr(MSR_TEMPERATURE_TARGET, msr);
> This patch breaks all Siemens APL mainboards. This part was not executed in the old function. […]

Sorry about that Mario, we're going through an effort to try and move as much Intel SoC-specific code to src/soc/intel/common as possible. I am not aware of any general mechanism to detect fan presence in coreboot, but this can definitely be solved with a quick Kconfig change. I'll try to post that change ASAP. I'll see you and Werner as reviewers.