Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40425 )
Change subject: mb/google/volteer: Add support for USB Type-C ports
......................................................................
Patch Set 3:
(1 comment)
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40425/1/src/mainboard/google/voltee...
File src/mainboard/google/volteer/acpi/usbc.asl:
PS1:
With the generated SSDT PMC.MUX.CONx along with SSDT LPCB.EC0.CREC.USBC, the preliminary test shows USBC(GOOG0014) and PMC(INTC1026) are probed successfully.
Have you verified that the upstream Mux agent driver is probed successfully? HID = INTC105C. FWIU that is the driver that uses these properties. This driver is not in chromeos-5.4 yet, so you will have to verify it locally.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40425
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4b443a1ca1c5361652a69586b340b1c95e9c3f06
Gerrit-Change-Number: 40425
Gerrit-PatchSet: 3
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Caveh Jalali
caveh@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Prashant Malani
pmalani@google.com
Gerrit-Comment-Date: Mon, 27 Apr 2020 20:05:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: John Zhao
john.zhao@intel.com
Comment-In-Reply-To: Prashant Malani
pmalani@google.com
Gerrit-MessageType: comment