Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39838 )
Change subject: lp/drivers/usb: Work around QEMU XHCI register issue ......................................................................
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39838/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39838/1//COMMIT_MSG@7 PS1, Line 7: Workaround
The verb is spelled with a space: Work around.
Done
https://review.coreboot.org/c/coreboot/+/39838/1//COMMIT_MSG@16 PS1, Line 16: https://bugs.launchpad.net/qemu/+bug/1693050
Upstream says, this should be fixed since 2012 [1][2]. […]
Added a comment indicating the 2012 fix attempt does not work.
https://review.coreboot.org/c/coreboot/+/39838/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/xhci.c:
https://review.coreboot.org/c/coreboot/+/39838/1/payloads/libpayload/drivers... PS1, Line 190: CAP_GET(CAPLEN, xhci->capreg);
Does this fit in 96 characters?
it gets down to 91 if I remove the tab indent. the next two lines can though.
https://review.coreboot.org/c/coreboot/+/39838/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/usb/xhci_private.h:
https://review.coreboot.org/c/coreboot/+/39838/1/payloads/libpayload/drivers... PS1, Line 334: 12
oops yep
Done
https://review.coreboot.org/c/coreboot/+/39838/1/payloads/libpayload/drivers... PS1, Line 340: 1
good catch.. many of these aren't used so I guess I didn't notice.
Done