Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35290 )
Change subject: timestamps: Mostly remove struct timestamp_cache ......................................................................
Patch Set 1:
Patch Set 1:
Can we get a decision how amd/picasso will handle CBMEM console and timestamps prior to CBMEM becoming online?
I would rather remove TIMESTAMP_CACHE_IN_BSS. That would keep REGION(timestamp) somewhere in the linker scripts, even though PSP is likely not able to push any useful there.
Removing TIMESTAMP_CACHE_IN_BSS seems OK to me. I'm currently running w/timestamps and console outside of BSS before cbmem. And since I already need to reserve DRAM for early code and data, I don't see the downside of keeping it out of BSS.
As far as the PSP's concerned, it only provides data by writing to the AGESA PSP Output Block (APOB). That's a location we set at build time and the PSP reads it from the BIOS Directory Table we generate. (hmm, I should change that address to make it contiguous to my romstage & data in DRAM...) At the moment, the only plan is for the APOB to be consumed by AGESA.