Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31206 )
Change subject: Kconfig: Add system type entries for common enclosures
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/31206/4/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/#/c/31206/4/src/Kconfig@337
PS4, Line 337: SYSTEM_TYPE_LAPTOP || SYSTEM_TYPE_TABLET)
How about leaving this as `default n` like the others?
Boards that don't select anything wouldn't have a spurious
setting in their .config then. And the `default 0x03` would
still trigger for SMBIOS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31206
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I148ec2329a1dd38ad55c60ba277a514c66376fcc
Gerrit-Change-Number: 31206
Gerrit-PatchSet: 4
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt Delco
delco@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sat, 02 Feb 2019 14:39:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment