Attention is currently required from: Máté Kukri, Maxim Polyakov, Tristan Corrick, Arthur Heymans, Iru Cai.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30890 )
Change subject: autoport: Add support for Haswell-LynxPoint platform
......................................................................
Patch Set 33: Code-Review+1
(2 comments)
File util/autoport/bd82x6x.go:
https://review.coreboot.org/c/coreboot/+/30890/comment/5542ad6a_d7c211d0
PS32, Line 13: func writeGPIOSet(ctx Context, sb *os.File,
Should non-bd82x6x stuff be moved into a separate file?
Ping
File util/autoport/lynxpoint.go:
https://review.coreboot.org/c/coreboot/+/30890/comment/a48abbbd_290a2c7a
PS32, Line 24: switch g {
I would prefer to use a map here […]
Sounds good. GPIOs in LPT-LP are just numbers, so I wouldn't define names for them (8 means GPIO8, for example).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30890
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f6e8c97b5122101de2f36bba8ba9f8ddd5b813a
Gerrit-Change-Number: 30890
Gerrit-PatchSet: 33
Gerrit-Owner: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Daniel Maslowski
info@orangecms.org
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Jamal Wright
Crabstorage@getbackinthe.kitchen
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Pablo Stebler
pablo@stebler.xyz
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Christoph Pomaska
github@slrie.de
Gerrit-CC: Máté Kukri
kukri.mate@gmail.com
Gerrit-CC: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Máté Kukri
kukri.mate@gmail.com
Gerrit-Attention: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Attention: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Iru Cai
mytbk920423@gmail.com
Gerrit-Comment-Date: Fri, 25 Feb 2022 16:06:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment