Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47350 )
Change subject: lp4x: Add new memory parts and generate SPDs
......................................................................
Patch Set 3: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/47350/1/util/spd_tools/lp4x/global_...
File util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt:
https://review.coreboot.org/c/coreboot/+/47350/1/util/spd_tools/lp4x/global_...
PS1, Line 191: 2
As per [1], "Thus, number of diesPerPackage is the number of ZQ balls on the package. […]
Thanks, Furquan.
https://review.coreboot.org/c/coreboot/+/47350/1/util/spd_tools/lp4x/global_...
PS1, Line 203: 4
Please check as per the comment above.
Done
https://review.coreboot.org/c/coreboot/+/47350/1/util/spd_tools/lp4x/global_...
PS1, Line 215: 2
Please check as per the comment above.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47350
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37702770f707fe078920694468552c5db59c478f
Gerrit-Change-Number: 47350
Gerrit-PatchSet: 3
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Nov 2020 16:33:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment