HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31254 )
Change subject: mainboard/(i82801gx): Move early_ich7_init() to southbridge
......................................................................
Patch Set 6:
looks like this value is RO ...
I've set it by mistake to 0x10030549 https://review.coreboot.org/#/c/coreboot/+/25509/25/src/mainboard/nec/945g-m...
and using inteltool on that rom, I got 0x10030509.
so it needs more investigation and test on other boards ...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31254
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idab66c675b5bcb068a720a66e722b1d8275c19bb
Gerrit-Change-Number: 31254
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 06 Feb 2019 21:42:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment