Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42029 )
Change subject: smbios: Add option VPD_SMBIOS_VERSION that reads BIOS version from a VPD variable
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42029/11/src/arch/x86/smbios.c
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/42029/11/src/arch/x86/smbios.c@373
PS11, Line 373: #if !CONFIG(CHROMEOS)
ChromeOS would see build error: […]
Sorry, I did not realize there was so much existing ugliness for CONFIG(CHROMEOS) in here. Yes, if you could move the t->bios_version part out of the #if CONFIG(CHROMEOS) block down there, and then implement the spaces stuff equivalently (with a C if (CONFIG(CHROMEOS))) inside get_bios_version(), that would be great.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42029
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee62ed900095001ffac225fc629b3f2f52045e30
Gerrit-Change-Number: 42029
Gerrit-PatchSet: 12
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: insomniac
insomniac@slackware.it
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 18 Jun 2020 21:33:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment