Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38639 )
Change subject: soc/intel/common/systemagent: add Kconfig guard ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38639/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38639/1//COMMIT_MSG@9 PS1, Line 9: Looks like having this in the tree force-sets MMCONF_BASE_ADDR to : some value which can't be overriden anywhe
I am still confused how this change would help. […]
actually I am selecting SOC_INTEL_COMMON, because I need to select quite a bit of code in soc/intel/common/block
https://review.coreboot.org/c/coreboot/+/38639/2/src/mainboard/intel/harcuva... File src/mainboard/intel/harcuvar/Kconfig:
https://review.coreboot.org/c/coreboot/+/38639/2/src/mainboard/intel/harcuva... PS2, Line 45: config MMCONF_BASE_ADDRESS
Instead of adding these to mainboard, I think it would be better to add these to soc/intel/denverton […]
the best idea would be for denverton to select SOC_INTEL_COMMON_BLOCK_SA and start using "common" systemagent code, if it is possible. But ok, I just moved the definition to Kconfig which is far better place for it, thanks