Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32651 )
Change subject: soc/amd/stoneyridge: Move GPIO support to common ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/32651/3/src/soc/amd/common/block/include/amd... File src/soc/amd/common/block/include/amdblocks/gpio.h:
https://review.coreboot.org/#/c/32651/3/src/soc/amd/common/block/include/amd... PS3, Line 303: size_t soc_gpio_event_table_size(void); : int soc_override_event(uint8_t gpio, uint8_t mux, uint8_t *event);
It would be helpful to add comments indicating: […]
Done
https://review.coreboot.org/#/c/32651/3/src/soc/amd/stoneyridge/gpio.c File src/soc/amd/stoneyridge/gpio.c:
https://review.coreboot.org/#/c/32651/3/src/soc/amd/stoneyridge/gpio.c@49 PS3, Line 49: soc_gpio_event_table_size
Can this be instead renamed to soc_gpio_get_event_table_details which can fill in pointer to event t […]
Done with different name.