[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Add ASL function for setting pad mode

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31444 )

Change subject: soc/intel/cannonlake: Add ASL function for setting pad mode
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/31444/2/src/soc/intel/cannonlake/acpi/gpio_o... 
File src/soc/intel/cannonlake/acpi/gpio_op.asl:

https://review.coreboot.org/#/c/31444/2/src/soc/intel/cannonlake/acpi/gpio_o... 
PS2, Line 91: PADM, 2,
> Can you point me to the bug, I am not aware of this issue. […]

We had run into this with PME status/control registers: https://review.coreboot.org/c/20364/

and https://review.coreboot.org/c/coreboot/+/23848

I am not sure if those apply to the GPIO regs, but just want to make sure we don't run into unexpected issues later.