Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37783 )
Change subject: soc/intel/tigerlake: Update chip files ......................................................................
Patch Set 30:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37783/22/src/soc/intel/tigerlake/ch... File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/37783/22/src/soc/intel/tigerlake/ch... PS22, Line 135: /* Need to update DLL setting to get Emmc running at HS400 speed */ : uint8_t EmmcUseCustomDlls; : uint32_t EmmcTxCmdDelayRegValue; : uint32_t EmmcTxDataDelay1RegValue; : uint32_t EmmcTxDataDelay2RegValue; : uint32_t EmmcRxCmdDataDelay1RegValue; : uint32_t EmmcRxCmdDataDelay2RegValue; : uint32_t EmmcRxStrobeDelayRegValue;
Why is EmmcUseCustomDlls required? We can just configure the EMMC DLL params in coreboot using DLL p […]
EmmcUseCustomDlls is required in case we want to configure custom DLL values from FSP instead of platform defaults.
Can we done via coreboot too using INTEL_COMMON_MMC_OVERRIDE, but since FSP allows custom dll programming, we can leverage that and use the soc_intel_common dll params to initialize dll tuning UPDsfor FSP. Thoughts?
https://review.coreboot.org/c/coreboot/+/37783/22/src/soc/intel/tigerlake/ch... PS22, Line 145: SdCardPowerEnableActiveHigh
My point is that there is no code under src/soc/intel/tigerlake which actually uses this config. […]
Can we keep it for JSL? JSL would use this, it would not add into unused configs.