Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44661 )
Change subject: mb/google/dedede/var/drawcia: Add Wifi SAR for drawcia ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44661/11/src/mainboard/google/deded... File src/mainboard/google/dedede/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/44661/11/src/mainboard/google/deded... PS11, Line 23: select FW_CONFIG : select FW_CONFIG_SOURCE_CHROMEEC_CBI This can be moved under BOARD_GOOGLE_BASEBOARD_DEDEDE in Kconfig file since we will use FW_CONFIG for all of dedede. Probably better to split that into a separate patch.
https://review.coreboot.org/c/coreboot/+/44661/11/src/mainboard/google/deded... File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44661/11/src/mainboard/google/deded... PS11, Line 2: field TABLETMODE 10 FW_CONFIG bit 10 is used to identify tablet mode for all of dedede. So please move this to variants/baseboard/devicetree.cb. Also as part of the change which moves the FW_CONFIG to Kconfig.