Attention is currently required from: Furquan Shaikh, Sumeet R Pawnikar, Patrick Rudolph, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57095 )
Change subject: soc/intel/common: Add PMC IPC commands for FIVR
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/include/acpi/acpigen_dptf.h:
https://review.coreboot.org/c/coreboot/+/57095/comment/a0bc1d28_aee1e4bd
PS1, Line 16: #define TPCH_DEVICE_PATH "\_SB.TPCH"
This doesn't look required from the spec or from the kernel driver. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57095
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccb43b7ba4f0765499bf1844efbbb526bd671a8f
Gerrit-Change-Number: 57095
Gerrit-PatchSet: 3
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 01 Sep 2021 21:12:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment