[coreboot-gerrit] Change in coreboot[master]: device/pci: Enable full 16-bit VGA port i/o decoding

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35516 )

Change subject: device/pci: Enable full 16-bit VGA port i/o decoding
......................................................................

Patch Set 2: Code-Review+1

(1 comment)

I think the approach here is a good compromise. Should fix recent platforms and not break older ones. Maybe commit message could say use of VGA cards on AGP and (parallel) PCI slots may have issues due to aliasing, and reference the error messages we add here.

https://review.coreboot.org/c/coreboot/+/35516/2/src/device/device.c 
File src/device/device.c:

https://review.coreboot.org/c/coreboot/+/35516/2/src/device/device.c@799 
PS2, Line 799: 
Can we add this:

bool vga_io_10bit_decode(void)
   {
      return (vga_pri && vga_pri->bus->no_vga16);    
   }

I might try to fix the 'aliasing avoidance' or just throw errors after resource assignments.