Magf - has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43319 )
Change subject: mb/google/kukui: fix damu touchscreen reset sequence ......................................................................
Patch Set 3:
(2 comments)
Have fixed, please help review again, thanks.
https://review.coreboot.org/c/coreboot/+/43319/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43319/2//COMMIT_MSG@13 PS2, Line 13: But when warm reboot, because : kernel will not pull it low, if we want a reset, we can pull it low : and rely on kernel to release it to get a valid reset > 500us. :
In warm boot, we have to pull it low in firmware stage so kernel can release it to get a valid reset […]
Done
https://review.coreboot.org/c/coreboot/+/43319/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/43319/2/src/mainboard/google/kukui/... PS2, Line 198: configure_touchscreen();
We want to configure emmc & USB as early as possible. […]
Done