build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31027 )
Change subject: nb/intel/i945: Use macro instead of magic number
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/31027/4/src/northbridge/intel/i945/raminit.c
File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/#/c/31027/4/src/northbridge/intel/i945/raminit.c...
PS4, Line 256: pci_write_config8(PCI_DEV(0, 0x1f, 0), GEN_PMCON_2, reg8);
line over 80 characters
https://review.coreboot.org/#/c/31027/4/src/northbridge/intel/i945/raminit.c...
PS4, Line 264: pci_write_config8(PCI_DEV(0, 0x1f, 0), GEN_PMCON_2, reg8);
line over 80 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31027
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I028013bd7511b5b9fc80e5f744fcad584cb25fd3
Gerrit-Change-Number: 31027
Gerrit-PatchSet: 4
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 08 May 2019 12:43:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment